Re: [PATCH -next v2] gpio: raspberrypi-exp: remove redundant of_match_ptr()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Aug 2, 2023 at 5:49 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here, and __maybe_unused can also be removed.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.
>
> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ---
> Changes in v2:
> - Change of_match_ptr to of_match_ptr() in the commit message.
> ---
>  drivers/gpio/gpio-raspberrypi-exp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c
> index ecb0d3800dfe..9d1b95e429f1 100644
> --- a/drivers/gpio/gpio-raspberrypi-exp.c
> +++ b/drivers/gpio/gpio-raspberrypi-exp.c
> @@ -234,7 +234,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev)
>         return devm_gpiochip_add_data(dev, &rpi_gpio->gc, rpi_gpio);
>  }
>
> -static const struct of_device_id rpi_exp_gpio_ids[] __maybe_unused = {
> +static const struct of_device_id rpi_exp_gpio_ids[] = {
>         { .compatible = "raspberrypi,firmware-gpio" },
>         { }
>  };
> @@ -243,7 +243,7 @@ MODULE_DEVICE_TABLE(of, rpi_exp_gpio_ids);
>  static struct platform_driver rpi_exp_gpio_driver = {
>         .driver = {
>                 .name           = MODULE_NAME,
> -               .of_match_table = of_match_ptr(rpi_exp_gpio_ids),
> +               .of_match_table = rpi_exp_gpio_ids,
>         },
>         .probe  = rpi_exp_gpio_probe,
>  };
> --
> 2.17.1
>

Applied, thanks!

Bart