Re: [PATCH -next v2] gpio: max732x: remove redundant CONFIG_OF and of_match_ptr()

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Aug 2, 2023 at 6:54 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here. We remove both CONFIG_OF and of_match_ptr() here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.

...

>  #include <linux/platform_data/max732x.h>
> -#include <linux/of.h>
>

It seems you may also drop the extra blank line here.

>
>  /*

I hope no resend is needed and Bart can amend this when applying.

-- 
With Best Regards,
Andy Shevchenko