Re: [PATCH -next v2] gpio: tps65218: remove redundant of_match_ptr()

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Aug 2, 2023 at 6:53 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr().

...

>         .driver = {
>                 .name = "tps65218-gpio",
> -               .of_match_table = of_match_ptr(tps65218_dt_match)
> +               .of_match_table = tps65218_dt_match

Sorry, haven't seen it before, but it's good to add a trailing comma
here, while you are touching this line. Perhaps no resending needed
and Bart can amend when applying.

>         },


-- 
With Best Regards,
Andy Shevchenko