Re: [PATCH -next v2] gpio: xra1403: remove redundant of_match_ptr()

[Andy Shevchenko <andy@xxxxxxxxxx>]

On Wed, Aug 02, 2023 at 12:02:32PM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here, and __maybe_unused can also be removed.
> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.

> Since spi.h included mod_devicetable.h, so we drop mod_devicetable.h.

Okay, but it's other way around, "we don't include it if it was missing".
Sorry, I was probably unclear about this. Here it's fine and good that
it's included explicitly, no need to drop.

-- 
With Best Regards,
Andy Shevchenko