Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs

[Hector Martin <marcan@xxxxxxxxx>]

On 06/09/2022 04.10, Linus Walleij wrote:
> On Mon, Sep 5, 2022 at 6:13 PM Russell King (Oracle)
> <linux@xxxxxxxxxxxxxxx> wrote:
> 
>> I suggest that I try resubmitting the series with IRQ support dropped,
>> and with the %p4ch support in it and we'll see what happens.
> 
> You can add my
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> on the result, and the code should go in when Hector & you are
> happy with it. I surely trust you to fix the final polish.
> 
> I don't mind the IRQ patch either, but I understand it's a bit
> annoying if you can't test it on anything.

Thank you!

FWIW, I wrote that commit as part of working on PCIe power saving and
the SD card reader specifically, where the SMC GPIO card detect pin can
replace the internal card detect, and this allows us to completely power
down the SD card reader when there is no card inserted. But that PCIe
power management code isn't anywhere near done yet, I just tested that
using the SMC card detect IRQ works as expected with sdhci-pci. So it's
perfectly fine to hold off on that patch until later, and submit it once
we've actually been using it downstream for a bit and it gets some testing.

- Hector