Re: [PATCH v3 12/21] pinctrl: renesas: r8a779g0: add missing HSCIF1_X

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Morimoto-san,

On Tue, Jun 14, 2022 at 7:59 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> This patch adds missing HSCIF1.
> Because Document has 2xHSCIF1 with no suffix (_A, _B),
> this patch name it as _X.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c
> @@ -1554,6 +1561,29 @@ static const unsigned int hscif1_ctrl_mux[] = {
>         HRTS1_N_MARK, HCTS1_N_MARK,
>  };
>
> +/* - HSCIF1_X---------------------------------------------------------------- */
> +static const unsigned int hscif1_x_data_pins[] = {

hscif1_data_x_pins etc.

> +       /* HRX1_X, HTX1_X */
> +       RCAR_GP_PIN(1, 7), RCAR_GP_PIN(1, 6),
> +};

> @@ -2805,6 +2844,7 @@ static const struct sh_pfc_function pinmux_functions[] = {
>
>         SH_PFC_FUNCTION(hscif0),
>         SH_PFC_FUNCTION(hscif1),
> +       SH_PFC_FUNCTION(hscif1_x),

Please drop this.

>         SH_PFC_FUNCTION(hscif2),
>         SH_PFC_FUNCTION(hscif3),
>         SH_PFC_FUNCTION(hscif3_a),

Again, as the pin group names are part of the DT ABI, this cannot be
applied as-is, and we have to wait for clarification of the suffixes.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds