Re: [PATCH v2 1/3] pinctrl: amd: Define and use PINCTRL_GRP

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, May 24, 2022 at 4:39 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, May 24, 2022 at 10:13 AM Basavaraj Natikar
> <Basavaraj.Natikar@xxxxxxx> wrote:
> >
> > AMD pingroup can be extended to support multi-function pins.
> > Hence define and use PINCTRL_GRP to manage and represent
> > larger number of pingroups inline.
>
> This is good idea, but please make it available for all pin control
> drivers, since the data structure like
>
>   pingroup {
>     *name;
>     *pins;
>     npins;
>   }
>
> is used in many drivers.
>
> That said, I think the AMD_ prefix will be misleading in this case.

Aha you mean like a utility macro? That's useful, don't know where to put it
though, include/linux/pinctrl/pinmux.h?

Yours,
Linus Walleij