Re: [PATCH v2 1/3] pinctrl: amd: Define and use PINCTRL_GRP

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, May 24, 2022 at 10:13 AM Basavaraj Natikar
<Basavaraj.Natikar@xxxxxxx> wrote:
>
> AMD pingroup can be extended to support multi-function pins.
> Hence define and use PINCTRL_GRP to manage and represent
> larger number of pingroups inline.

This is good idea, but please make it available for all pin control
drivers, since the data structure like

  pingroup {
    *name;
    *pins;
    npins;
  }

is used in many drivers.

That said, I think the AMD_ prefix will be misleading in this case.

...

> +#define PINCTRL_GRP(_name, _pins, _npins) \
> +       { .name = _name, .pins = _pins, .npins = _npins}

Please, don't forget spaces and commas, also it would be better to
1) split {} on the separate lines;
2) make it compound literal, so one can use it in the code.

-- 
With Best Regards,
Andy Shevchenko