Hi Sowjanya, thanks for your patches! On Tue, Aug 24, 2021 at 6:48 PM <lakshmi.sowjanya.d@xxxxxxxxx> wrote: > From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@xxxxxxxxx> > > Starting with Intel(R) Tiger Lake and Elkhart Lake platforms the PMC > hardware adds the Timed I/O hardware interface. > > The Timed I/O hardware implements some functionality similar to GPIO > with added timing logic that is driven by the Always Running Timer > (ART). > > The Timed I/O Hardware implement 3 basic functions: > * Input Timestamping > * Single Shot Timed Output > * Periodic Timed Output > > Please help to review the changes. This looks very similar to the usecase proposed for the HTE Hardware Timestamping Engine, proposed by Dipen Patel for the nVidia 194 and which is currently in RFC: https://lore.kernel.org/linux-gpio/20210625235532.19575-1-dipenp@xxxxxxxxxx/ Please review this new subsystem and see if you can just make a slot-in driver using Dipen's patches instead. Dipen: please have a look at Sowjanya's patches to see if this hardware is similar to yours. Sometimes several vendors come up with similar hardware around the same time, because of industry trends, so I would not be surprised if these two hardwares address the very same usecase. Yours, Linus Walleij