On Tue, Jun 15, 2021 at 05:45:58PM -0600, Rob Herring wrote: > On Wed, Jun 02, 2021 at 02:03:25PM +0200, Jonathan Neuschäfer wrote: > > This binding is heavily based on the one for NPCM7xx, because the > > hardware is similar. One notable difference is that there are no > > sub-nodes for GPIO banks, because the GPIO registers are arranged > > differently. > > > > Certain pins support blink patterns in hardware. This is currently not > > modelled in the DT binding. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> > > --- [...] > > +properties: > > + compatible: > > + const: "nuvoton,wpcm450-pinctrl" > > Don't need quotes. Ok, I'll remove them. > > > + > > + reg: > > + maxItems: 1 > > + > > + gpio-controller: true > > + > > + '#gpio-cells': > > + const: 2 > > + > > + interrupt-controller: true > > + > > + "#interrupt-cells": > > + const: 2 and I just noticed the inconsistency in quotes here. I'll fix it. > > + > > + interrupts: true > > + > > +patternProperties: > > + # There are two kinds of subnodes: > > + # 1. a pinmux node configures pin muxing for a group of pins (e.g. rmii2) > > + # 2. a pinctrl node configures properties of a single pin > > + "^.*$": > > + if: > > + type: object > > + then: > > Don't do this hack for new bindings. Pick a node name pattern you can > match on. Ok. > > > + allOf: > > + - $ref: pincfg-node.yaml# > > + - $ref: pinmux-node.yaml# > > + properties: [...] > > + phandle: true > > Needing this should be fixed now. Ok, I'll drop it. Thanks, Jonathan Neuschäfer
Attachment:
signature.asc
Description: PGP signature
