On Fri, May 21, 2021 at 12:53 PM Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote: > > The set_config and init_valid_mask GPIO operations are usually very IC > specific. Allow IC drivers to provide these custom operations at > gpio-regmap registration. Thanks for this. In general (from design p.o.v.) looks good to me, one question below, though. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > --- > Changelog v2: (based on suggestions by Michael Walle) > - drop gpio_regmap_set_drvdata() But why do we have gpio_regmap_get_drvdata() and why is it different now to the new member handling? > - drop checks and WARN() for pretty much impossible cases -- With Best Regards, Andy Shevchenko