On Wed, Dec 18, 2019 at 9:44 AM Peng Fan <peng.fan@xxxxxxx> wrote: > - nr_irq_parent = of_irq_count(np); > + nr_irq_parent = platform_irq_count(pdev); > + if (nr_irq_parent < 0) { > + if (nr_irq_parent != -EPROBE_DEFER) > + dev_err(dev, "Couldn't determine irq count: %pe\n", > + ERR_PTR(nr_irq_parent)); Why do you return ERR_PTR(nr_irq_parent) instead of simply nr_irq_parent?