> Subject: Re: [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api > > On Wed, Dec 18, 2019 at 9:44 AM Peng Fan <peng.fan@xxxxxxx> wrote: > > > - nr_irq_parent = of_irq_count(np); > > + nr_irq_parent = platform_irq_count(pdev); > > + if (nr_irq_parent < 0) { > > + if (nr_irq_parent != -EPROBE_DEFER) > > + dev_err(dev, "Couldn't determine irq > count: %pe\n", > > + ERR_PTR(nr_irq_parent)); > > Why do you return ERR_PTR(nr_irq_parent) instead of simply nr_irq_parent? Please see: https://lkml.org/lkml/2019/12/4/64 and the patch in tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/ commit/?id=cfdca14c44a79b9c9c491235a39b9fc1e520820b Thanks, Peng.