Re: [PATCH] pinctrl: imx: off by one in imx_pinconf_group_dbg_show()

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

On Mon, Jul 30, 2018 at 08:47:15AM +0000, A.s. Dong wrote:
> > -----Original Message-----
> > From: Uwe Kleine-König [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> > Sent: Monday, July 30, 2018 2:42 PM
> > To: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>; A.s. Dong
> > <aisheng.dong@xxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; kernel-
> > janitors@xxxxxxxxxxxxxxx; Stefan Agner <stefan@xxxxxxxx>; open list:GPIO
> > SUBSYSTEM <linux-gpio@xxxxxxxxxxxxxxx>; Sascha Hauer
> > <kernel@xxxxxxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>
> > Subject: Re: [PATCH] pinctrl: imx: off by one in
> > imx_pinconf_group_dbg_show()
> > 
> > On Sun, Jul 29, 2018 at 11:23:36PM +0200, Linus Walleij wrote:
> > > On Thu, Jul 19, 2018 at 10:17 AM Dan Carpenter
> > <dan.carpenter@xxxxxxxxxx> wrote:
> > >
> > > > The > should really be >= here.  It's harmless because
> > > > pinctrl_generic_get_group() will return a NULL if group is invalid.
> > > >
> > > > Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core
> > > > driver")
> > > > Reported-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > >
> > > Patch applied.
> > 
> > I see that you applied the imx_pinconf_group_dbg_show patch, but not the
> > one specific to imx1 earlier in this thread. These are orthogonal and so both
> > should be applied.
> > 
> 
> Right.
> 
> BTW just let you know, unlike that patch, this one is just a simple improvement 
> and don't have to go to stable tree.

To clearify: the imx1 change (ie. the one currently missed) is the
critical one as it fixes an out-of-bounds access.
imx_pinconf_group_dbg_show was harmless, the only change is that with it
applied there is one "\n" less in the output.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html