RE: [PATCH] pinctrl: imx: off by one in imx_pinconf_group_dbg_show()

["A.s. Dong" <aisheng.dong@xxxxxxx>]

> -----Original Message-----
> From: Uwe Kleine-König [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> Sent: Monday, July 30, 2018 2:42 PM
> To: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>; A.s. Dong
> <aisheng.dong@xxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; kernel-
> janitors@xxxxxxxxxxxxxxx; Stefan Agner <stefan@xxxxxxxx>; open list:GPIO
> SUBSYSTEM <linux-gpio@xxxxxxxxxxxxxxx>; Sascha Hauer
> <kernel@xxxxxxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>
> Subject: Re: [PATCH] pinctrl: imx: off by one in
> imx_pinconf_group_dbg_show()
> 
> On Sun, Jul 29, 2018 at 11:23:36PM +0200, Linus Walleij wrote:
> > On Thu, Jul 19, 2018 at 10:17 AM Dan Carpenter
> <dan.carpenter@xxxxxxxxxx> wrote:
> >
> > > The > should really be >= here.  It's harmless because
> > > pinctrl_generic_get_group() will return a NULL if group is invalid.
> > >
> > > Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core
> > > driver")
> > > Reported-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > Patch applied.
> 
> I see that you applied the imx_pinconf_group_dbg_show patch, but not the
> one specific to imx1 earlier in this thread. These are orthogonal and so both
> should be applied.
> 

Right.

BTW just let you know, unlike that patch, this one is just a simple improvement 
and don't have to go to stable tree.

Regards
Dong Aisheng

> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 |
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
> w.pengutronix.de%2F&amp;data=02%7C01%7Caisheng.dong%40nxp.com%7
> C4d3365909e4347b199f608d5f5e787e5%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C636685297127964877&amp;sdata=RpfBCPK%2Fuom9gUGN
> wPCAY%2FR8nK67S66ryT9z5g3HM1k%3D&amp;reserved=0  |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html