Re: [PATCH] pinctrl: imx: off by one in imx_pinconf_group_dbg_show()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 30, 2018 at 11:04:59AM +0200, Linus Walleij wrote:
> On Mon, Jul 30, 2018 at 8:41 AM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > On Sun, Jul 29, 2018 at 11:23:36PM +0200, Linus Walleij wrote:
> > > On Thu, Jul 19, 2018 at 10:17 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > >
> > > > The > should really be >= here.  It's harmless because
> > > > pinctrl_generic_get_group() will return a NULL if group is invalid.
> > > >
> > > > Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
> > > > Reported-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > >
> > > Patch applied.
> >
> > I see that you applied the imx_pinconf_group_dbg_show patch, but not the
> > one specific to imx1 earlier in this thread. These are orthogonal and so
> > both should be applied.
> 
> Oh I'm sorry if I missed something... which subject does the missing
> patch have?

The subject is:

pinctrl: freescale: off by one in imx1_pinconf_group_dbg_show() 

(Note it only differs by s/imx/imx1/ from the patch you already took.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux