Re: Re: [PATCH] gpiolib: friendly debug information for consumer

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Feb 8, 2018 at 6:51 AM, Wang, Dongsheng
<dongsheng.wang@xxxxxxxxxxxxxxxx> wrote:

>>But the message is correct?
>>
>>>-               dev_dbg(dev, "lookup for GPIO %s failed\n", con_id);
>>
>>This is happening.
>>
>>I would be more inclined to agree if it was dev_err() but this is
>>not even info, it is debug info.
>>
> dev_dbg is often used when we develop code. I've been asked recently
> about this GPIO "failed", and others may be less familiar with GPIO.

Aha I understand.

> I'm also not familiar with it, just do some quick research here. :)
> So them confuse why kernel got this. In fact, there is no such GPIO
> feature(external PHY reset GPIO) on our platform. Therefore, I prefer
> not to use the word "failed".
>
> May be "No GPIO consumer %s found" is better?

That is fine!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html