Re: [PATCH] gpiolib: friendly debug information for consumer

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Wang,

thank you for your patch!

On Tue, Jan 23, 2018 at 6:28 AM, Wang Dongsheng
<dongsheng.wang@xxxxxxxxxxxxxxxx> wrote:

> mdiobus always try to get "reset" consumer, but not all platforms
> have this capability. "failed" makes observer confuse when a
> consumer can not find.
>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@xxxxxxxxxxxxxxxx>

But the message is correct?

> -               dev_dbg(dev, "lookup for GPIO %s failed\n", con_id);

This is happening.

I would be more inclined to agree if it was dev_err() but this is
not even info, it is debug info.

> +               dev_dbg(dev, "Can not detect GPIO consumer %s\n", con_id);

This is not about any "detection", it is about looking something
up.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html