Re: [PATCH v2 0/3] gpio: davinci: Add missing return checks

[Suman Anna <s-anna@xxxxxx>]

Hi Keerthy,

> 
> On Thursday 20 July 2017 03:12 PM, Keerthy wrote:
>> The patch series does a couple of important return handling which were missed
>> earlier in the driver probe.
>>
>> This is based on Suman's:
>>
>> http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2
>> http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2 
>>
> 
> My bad! The series has no dependency on the above. I have split the
> device tree patches to keep it independent.

The new patches looks clean. The davinci_gpio_irq_setup() function
though could also do with couple more cleanups. Not all failure paths
are doing the necessary cleanup (there are some non devres functions
also called, but not cleaned up).

regards
Suman

> 
>> Changes in v2:
>>
>>   * Removed the device tree patch for to keep the series independent.
>>
>> Keerthy (3):
>>   gpio: davinci: Use devm_gpiochip_add_data in place of
>>     gpiochip_add_data
>>   gpio: davinci: Handle the return value of davinci_gpio_irq_setup
>>     function
>>   gpio: davinci: Convert prinkt to dev_err
>>
>>  drivers/gpio/gpio-davinci.c | 22 +++++++++++++++++-----
>>  1 file changed, 17 insertions(+), 5 deletions(-)
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html