Stephen Boyd wrote:
> The idea is to notify drivers with an error code when they make a > mistake. Perhaps the device tree or the ACPI table has an error?
In general the kernel isn't a firmware validator. At least that's the way I view it. Others may have different opinions here.
I would be okay with wrapping that check around #ifdef CONFIG_DEBUG_GPIO.
> I could add that, but I still think returning an error code is > appropriate. On the TLMM, we know for sure that the pin must be set > to function 0 in order for the read/write routines to operate > correctly.
On ACPI we could make the gpio_get() path fail if the pin isn't in GPIO mode?
Did you mean the gpio_chip.request callback? Currently that points to gpiochip_generic_request in pinctrl-msm.c.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
