On Sat, Feb 11, 2017 at 12:25 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 02/10/2017 03:21 PM, Timur Tabi wrote: >> + return val & BIT(g->oe_bit) ? 0 : 1; > > Maybe we can use the macros GPIOF_DIR_IN and GPIOF_DIR_OUT here instead? Actually no. The GPIOF* #defines are for the consumer side of GPIO, not the driver side. We actually just use 0/1 in drivers. So I merged this v1 version. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html