Re: [PATCH] pinctrl: spacemit: enable config option

[Yixun Lan <dlan@xxxxxxxxxx>]

On 16:03 Tue 11 Feb     , Conor Dooley wrote:
> On Fri, Feb 07, 2025 at 10:37:05PM +0000, Yixun Lan wrote:
> > On 16:49 Fri 07 Feb     , Conor Dooley wrote:
> > > On Fri, Feb 07, 2025 at 08:11:42PM +0800, Yixun Lan wrote:
> > > > diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> > > > index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
> > > > --- a/drivers/pinctrl/spacemit/Kconfig
> > > > +++ b/drivers/pinctrl/spacemit/Kconfig
> > > > @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
> > > >  	tristate "SpacemiT K1 SoC Pinctrl driver"
> > > >  	depends on ARCH_SPACEMIT || COMPILE_TEST
> > > >  	depends on OF
> > > > +	default ARCH_SPACEMIT
> > > 
> > > This is effectively just "default y", since ARCH_SPACEMIT is a
> > > dependency.
> > > 
> > right, this is the plan, it make sense to bundle this config to ARCH_SPACEMIT
> 
> I don't think I was clear, I was trying to say that you should do
> s/ARCH_SPACEMIT/y/ on this line.

make sense, since we already have "depends on ARCH_SPACEMIT" here,
it's kind of redundant to say ARCH_SPACEMIT again, will fix in v2

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55