Pinctrl is an essential driver for SpacemiT's SoC, so let's enable it by default for this SoC. The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using 'make defconfig' to select kernel configuration options. This result in a broken uart driver where fail at probe() stage due to no pins found. Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC") Reported-by: Alex Elder <elder@xxxxxxxxxx> Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx> --- This should fix problem that CONFIG_PINCTRL_SPACEMIT_K1 is not enabled when using make defconfig, thus fail to initilize uart driver which requst pins during probe stage. --- arch/riscv/Kconfig.socs | 1 + drivers/pinctrl/spacemit/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs index 1916cf7ba450ec9958265de2ca41dc504d4d2f7c..17606940bb5239d0fdfc6b5aefb50eeb982d14aa 100644 --- a/arch/riscv/Kconfig.socs +++ b/arch/riscv/Kconfig.socs @@ -26,6 +26,7 @@ config ARCH_SOPHGO config ARCH_SPACEMIT bool "SpacemiT SoCs" + select PINCTRL help This enables support for SpacemiT SoC platform hardware. diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644 --- a/drivers/pinctrl/spacemit/Kconfig +++ b/drivers/pinctrl/spacemit/Kconfig @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1 tristate "SpacemiT K1 SoC Pinctrl driver" depends on ARCH_SPACEMIT || COMPILE_TEST depends on OF + default ARCH_SPACEMIT select GENERIC_PINCTRL_GROUPS select GENERIC_PINMUX_FUNCTIONS select GENERIC_PINCONF --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250207-k1-pinctrl-option-de5bdfd6b42e Best regards, -- Yixun Lan