Re: [PATCH v5 02/12] driver core: Split devres APIs to device/devres.h

["Arnd Bergmann" <arnd@xxxxxxxx>]

On Wed, Feb 12, 2025, at 07:25, Raag Jadav wrote:
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> device.h is a huge header which is hard to follow and easy to miss
> something. Improve that by splitting devres APIs to device/devres.h.
>
> In particular this helps to speedup the build of the code that includes
> device.h solely for a devres APIs.
>
> While at it, cast the error pointers to __iomem using IOMEM_ERR_PTR()
> and fix sparse warnings.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>
> ---
>  include/linux/device.h        | 119 +-------------------------------
>  include/linux/device/devres.h | 124 ++++++++++++++++++++++++++++++++++

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Splitting this out makes a lot of sense conceptually, though
I don't think it will actually help with build speed: In order
to see real benefits, we'd need to remove the linux/device.h
inclusion from other headers that are frequently included,
but those don't really rely on the devres interfaces.

    Arnd