Re: [PATCH v5 02/12] driver core: Split devres APIs to device/devres.h

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Feb 12, 2025 at 07:41:47AM +0100, Arnd Bergmann wrote:
> On Wed, Feb 12, 2025, at 07:25, Raag Jadav wrote:
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > device.h is a huge header which is hard to follow and easy to miss
> > something. Improve that by splitting devres APIs to device/devres.h.
> >
> > In particular this helps to speedup the build of the code that includes
> > device.h solely for a devres APIs.
> >
> > While at it, cast the error pointers to __iomem using IOMEM_ERR_PTR()
> > and fix sparse warnings.

...

> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Thank you!

> Splitting this out makes a lot of sense conceptually, though
> I don't think it will actually help with build speed: In order
> to see real benefits, we'd need to remove the linux/device.h
> inclusion from other headers that are frequently included,
> but those don't really rely on the devres interfaces.

Yeah, that's just yet another baby step to the right direction, but it won't
change picture if being alone. I already did a number of patches to split
kernel.h and removing it from other headers, but a lot of work is still ahead
and it's not my hight priority task...

-- 
With Best Regards,
Andy Shevchenko