Re: [PATCH 092/182] pinctrl: bcm2835: use gpiochip data pointer

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Dec 14, 2015 at 7:03 PM, Eric Anholt <eric@xxxxxxxxxx> wrote:
> Linus Walleij <linus.walleij@xxxxxxxxxx> writes:
>
>> On Fri, Dec 11, 2015 at 6:20 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
>>> On 12/09/2015 06:30 AM, Linus Walleij wrote:
>>>> This makes the driver use the data pointer added to the gpio_chip
>>>> to store a pointer to the state container instead of relying on
>>>> container_of().
>>>
>>> This looks like it's fine, but I wonder what is the justification for
>>> the change? It might be good to mention that in the commit description.
>>
>> It is in patch 000/182:
>> http://marc.info/?l=linux-gpio&m=144966662402660&w=2
>
> Thanks, that helps.
>
> I don't think it makes much sense to remove a module for a device that's
> opened,

That is not what we're afraid of really. We are afraid of the actual
device going away, like a GPIO on a USB cable that someone
unplugs.

> Acked-by: Eric Anholt <eric@xxxxxxxxxx>

Thanks.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html