Re: [PATCH 092/182] pinctrl: bcm2835: use gpiochip data pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Walleij <linus.walleij@xxxxxxxxxx> writes:

> On Fri, Dec 11, 2015 at 6:20 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
>> On 12/09/2015 06:30 AM, Linus Walleij wrote:
>>> This makes the driver use the data pointer added to the gpio_chip
>>> to store a pointer to the state container instead of relying on
>>> container_of().
>>
>> This looks like it's fine, but I wonder what is the justification for
>> the change? It might be good to mention that in the commit description.
>
> It is in patch 000/182:
> http://marc.info/?l=linux-gpio&m=144966662402660&w=2

Thanks, that helps.

I don't think it makes much sense to remove a module for a device that's
opened, but I don't really have any stake in the discussion.  So, for
the bcm2835 part:

Acked-by: Eric Anholt <eric@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux