Re: [PATCH 5/7] ASoC: wm5100: remove bitwise operations involving GPIO level value

[Vladimir Zapolskiy <vz@xxxxxxxxx>]

Hello Mark,

On 02.06.2015 22:45, Mark Brown wrote:
> On Tue, Jun 02, 2015 at 02:09:16AM +0300, Vladimir Zapolskiy wrote:
> 
>> @@ -2244,26 +2244,27 @@ static inline struct wm5100_priv *gpio_to_wm5100(struct gpio_chip *chip)
>>  static void wm5100_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
>>  {
>>  	struct wm5100_priv *wm5100 = gpio_to_wm5100(chip);
>> +	unsigned int val = 0;
>> +
>> +	if (value)
>> +		val = 0x1 << WM5100_GP1_LVL_SHIFT;
> 
> Write this as an if/else so the reader doesn't have to wonder why you've
> missed the handling of the false case.  
> 

the only objection I have is that the resulting code will be two lines
longer. If you think this code is not clear enough (is "val" vs. "value"
misleading?), I'll change the rest of my patches, which contain the same
logic structure, please let me know.

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html