Re: [PATCH] pinctrl: consumer: use correct retval for placeholder functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

> > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> >
> > These functions are supposed to return an error pointer, not NULL.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> 
> Worried that some driver may depend on this behaviour, but
> patch applied anyway, let's deal with it.

I sent a similar patch to Russell for the clk API and he rightfully
NAKed it. NULL is a valid cookie from clk_get and the whole clk API is
able to deal with NULL. That ensures that for !HAVE_CLK, clk_get is
still successful and won't fail driver_probe while the other clk API
functions don't really do anything. If the gpio API is similar to that,
we should revert my patch.

Sorry for the nuisance,

   Wolfram

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux