Re: [PATCH] pinctrl: consumer: use correct retval for placeholder functions

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Feb 9, 2015 at 4:00 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> Hi Linus,
>
>> > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>> >
>> > These functions are supposed to return an error pointer, not NULL.
>> >
>> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>>
>> Worried that some driver may depend on this behaviour, but
>> patch applied anyway, let's deal with it.
>
> I sent a similar patch to Russell for the clk API and he rightfully
> NAKed it. NULL is a valid cookie from clk_get and the whole clk API is
> able to deal with NULL. That ensures that for !HAVE_CLK, clk_get is
> still successful and won't fail driver_probe while the other clk API
> functions don't really do anything. If the gpio API is similar to that,
> we should revert my patch.

OK reverted for fixes, no big deal.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html