The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering gets bumped to one level earlier when we use the more appropriate fs_initcall here. However we've made similar changes before without any fallout and none is expected here either. We don't replace module.h with init.h since the file already has that. Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Jeff Layton <jlayton@xxxxxxxxxxxxxxx> Cc: "J. Bruce Fields" <bfields@xxxxxxxxxxxx> Cc: linux-fsdevel@xxxxxxxxxxxxxxx Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- fs/fcntl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/fcntl.c b/fs/fcntl.c index ee85cd4e136a..b485864eb357 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -13,7 +13,6 @@ #include <linux/capability.h> #include <linux/dnotify.h> #include <linux/slab.h> -#include <linux/module.h> #include <linux/pipe_fs_i.h> #include <linux/security.h> #include <linux/ptrace.h> @@ -755,5 +754,4 @@ static int __init fcntl_init(void) sizeof(struct fasync_struct), 0, SLAB_PANIC, NULL); return 0; } - -module_init(fcntl_init) +fs_initcall(fcntl_init) -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
