On Mon, Feb 23, 2015 at 09:39:47PM +0000, Al Viro wrote:
> On Mon, Feb 23, 2015 at 10:22:24PM +0100, Christoph Hellwig wrote:
> > On Mon, Feb 23, 2015 at 09:20:59PM +0000, Al Viro wrote:
> > > PS: I would prefer to rebase #iov_iter and #gadget to -rc1, actually...
> >
> > Btw, any chance to sneak dup_iter to Linus for this release? I ended
> > up adding an opencoded version to the block layer for this merge window,
> > and I'd prefer to get these consolidated ASAP.
>
> Hmm... Let's wait for USB folks to review those fixes - dup_iter() is
> helper needed for a fix of easily triggered use-after-free bug, after
> all, and beginning of the cycle is obviously OK for such.
While we are at it - once the situation with USB patches gets resolved,
I'm going to put that into vfs.git. If nothing else, O_DIRECT, O_APPEND and
probably O_NDELAY as well, need to be mirrored into ->ki_flags, to deal with
races on flipping those suckers during ->{read,write}_iter(). That, and
followup patches to affected filesystems out to go through vfs.git.
Another thing is that rw_copy_check_uvector() should be split in two helpers -
one to have iov_iter_init() folded into it, another being equivalent to
passing CHECK_IOVEC_ONLY (sg_io() and foreign address space treatment in
process_vm_readv()). Also vfs.git fodder, obviously, and should be on
top of that stuff.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
