On Tue, Sep 17, 2013 at 1:44 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Sep 17, 2013 at 12:16:56PM +0200, Miklos Szeredi wrote: > >> Just one. This needs to be removed, since this condition is now >> explicitly allowed and later checked for: >> >> if (WARN_ON(excl && !(*opened & FILE_CREATED))) >> *opened |= FILE_CREATED; > > D'oh... Fixed and pushed. Okay, but moving the fsnotify_create() to after the no-open section is wrong, I think, It's needed for the case of ->atomic_open() doing lookup/create/no_open too. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html