Re: [PATCH v2] hfsplus: avoid crash on failed block map free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 13, 2012 at 02:34:44PM -0800, Andrew Morton wrote:
> It looks better than what we currently have!
> 
> The code is missing a flush_dcache_page()?  We should have one in there
> after the CPU has modified userspace-mappable page contents.
> 
> 
> btw, I still have question marks over your earlier patches:
> 
> hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch
> hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch
> hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch
> hfsplus-add-support-of-manipulation-by-attributes-file.patch
> hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch
> hfsplus-code-style-fixes-reworked-support-of-extended-attributes.patch
> 
> Christoph sounded unhappy, but the review discussion petered out?

It really just needs the xattr namespace fixed.  JFS is a good model for
how to expose the legacy OS/2 attributes that are lacking a namespace prefix.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux