Hi, On Wed, 2012-11-14 at 12:24 +0100, Christoph Hellwig wrote: > On Tue, Nov 13, 2012 at 02:34:44PM -0800, Andrew Morton wrote: > > It looks better than what we currently have! > > > > The code is missing a flush_dcache_page()? We should have one in there > > after the CPU has modified userspace-mappable page contents. > > > > > > btw, I still have question marks over your earlier patches: > > > > hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch > > hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch > > hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch > > hfsplus-add-support-of-manipulation-by-attributes-file.patch > > hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch > > hfsplus-code-style-fixes-reworked-support-of-extended-attributes.patch > > > > Christoph sounded unhappy, but the review discussion petered out? > > It really just needs the xattr namespace fixed. JFS is a good model for > how to expose the legacy OS/2 attributes that are lacking a namespace prefix. So, likewise JFS model every pure Mac OS X xattr (for example, com.apple.FinderInfo) will be prefixed with "mac-os-x." during list_xattr stage. Then this prefix will be excluded for search in Catalog b-tree during get_xattr and set_xattr calls. And I try to rework the code for using general dispatching code also. Do you have any objections? :-) With the best regards, Vyacheslav Dubeyko. > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
