Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > Also, does it make sense to combine: > > > > if (!S_ISREG(nd->inode->i_mode)) > > will_truncate = 0; > > > > with: > > > > int will_truncate = open_flag & O_TRUNC; > > > > up at the top of the function. > > We need to check nd->inode->i_mode *after* the lookup. So top of the > function is not a good place. Good point. David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
