I've been looking at your patches when they're all applied, and I suspect you're missing some security calls. For instance, in lookup_open(), you call security_path_mknod() prior to calling vfs_create(), but you don't call it prior to calling atomic_open() or in, say, nfs_atomic_open(). You do need to, however, though I can see it's difficult to work out where. Is it possible to call it if O_CREAT is specified and d_inode is NULL right before calling atomic_open()? I'm also wondering if you're missing an audit_inode() call in the if (created) path after the retry_lookup label. David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html