Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > For instance, in lookup_open(), you call security_path_mknod() prior to > > calling vfs_create(), but you don't call it prior to calling atomic_open() > > or in, say, nfs_atomic_open(). > > We call security_path_mknod() before ->atomic_open() in may_o_create(). Okay. > > I'm also wondering if you're missing an audit_inode() call in the if > > (created) path after the retry_lookup label. > > There's no audit_inode() on the created dentry neither in the original > code nor in the modified code. > > But that may be a bug regardless, it's just independent of my changes. > At least AFAICS. Fair enough. David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html