Re: /proc/pid/fd/ shows strange mode when executed via sudo.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Al Viro wrote:
> On Fri, May 18, 2012 at 02:32:58PM -0700, Linus Torvalds wrote:
> > On Fri, May 18, 2012 at 2:26 PM, Linus Torvalds
> > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > However, wouldn't it be better to move the check you added to the
> > > readdir() path, then, so that we don't do it unnecessarily for
> > > lookups..
> > >
> > > I'll check how that looks.
> > 
> > Actually, we already do that. It's the fcheck_files() check in
> > proc_readfd_common(), no?
> 
> Missed that.  Yes, you are right - there's no point keeping that
> in proc_fd_instantiate().  OK, messing with fcheck_files() in there
> dropped now...

OK. As of commit 30a08bf2d "proc: move fd symlink i_mode calculations into
tid_fd_revalidate()", things are working as expected. Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux