On Fri, May 18, 2012 at 2:23 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> I would agree if we only called that on lookup. We also do that on
> readdir(), for every descriptor in range 0..files->max_fds-1. So
> if you have sufficiently sparse set of descriptors, it will be
> called a _lot_. Moreover, that's the usual path for calling it,
> exactly because we do getdents before trying to open/lstat/anything
> else.
Ahh, good catch.
However, wouldn't it be better to move the check you added to the
readdir() path, then, so that we don't do it unnecessarily for
lookups..
I'll check how that looks.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
