On Fri, May 18, 2012 at 2:26 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > However, wouldn't it be better to move the check you added to the > readdir() path, then, so that we don't do it unnecessarily for > lookups.. > > I'll check how that looks. Actually, we already do that. It's the fcheck_files() check in proc_readfd_common(), no? So I don't think we actually call that proc_fd_instantiate() function normally with out-of-range numbers. Afaik, only a (very rare) race, or an insane lookup of non-existent names would do it, neither of which looks like anything we should worry about. Am I missing some other path? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html