On Mon, Aug 08, 2011 at 11:58:00AM -0400, Josef Bacik wrote: > The test to make sure we support hole punching is just wrong. First it passes > the mode options into the len argument, and secondly it uses 0 for what I assume > was meant for the length, which doesn't work right. Also it uses warn instead > of just normal prt, which will cause xfstests to blow up for no reason. So fix > the arguments and the error message so that we can actually run xfstests with > fsx on fs's that don't support hole punching yet. Thanks, > > Signed-off-by: Josef Bacik <josef@xxxxxxxxxx> Already fixed: http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=c18bf42de9d5d5fa05025754df1ff63f2147bd12 Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html