I've been getting segfaults on fsx tests with btrfs because we're using the wrong values for the logging with fallocate. We were using the numbers 1,2 and 3 to indicate the type of preallocate we were doing, however we use these to point to an array, so obviously array[3] for a 3 element array is wrong, so fix these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to make it easier to figure out what's going on. Thanks, Signed-off-by: Josef Bacik <josef@xxxxxxxxxx> --- ltp/fsx.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ltp/fsx.c b/ltp/fsx.c index 0683853..662af38 100644 --- a/ltp/fsx.c +++ b/ltp/fsx.c @@ -878,11 +878,11 @@ do_preallocate(unsigned offset, unsigned length) /* * last arg: - * 1: allocate past EOF - * 2: extending prealloc - * 3: interior prealloc + * 0: allocate past EOF + * 1: extending prealloc + * 2: interior prealloc */ - log4(OP_FALLOCATE, offset, length, (end_offset > file_size) ? (keep_size ? 1 : 2) : 3); + log4(OP_FALLOCATE, offset, length, (end_offset > file_size) ? (keep_size ? 0 : 1) : 2); if (end_offset > file_size) { memset(good_buf + file_size, '\0', end_offset - file_size); @@ -895,7 +895,8 @@ do_preallocate(unsigned offset, unsigned length) if ((progressinterval && testcalls % progressinterval == 0) || (debug && (monitorstart == -1 || monitorend == -1 || end_offset <= monitorend))) - prt("%lu falloc\tfrom 0x%x to 0x%x\n", testcalls, offset, length); + prt("%lu falloc\tfrom 0x%x to 0x%x%s\n", testcalls, offset, length, + keep_size ? " (KEEP_SIZE)" : ""); if (fallocate(fd, keep_size ? FALLOC_FL_KEEP_SIZE : 0, (loff_t)offset, (loff_t)length) == -1) { prt("fallocate: %x to %x\n", offset, length); prterr("do_preallocate: fallocate"); -- 1.7.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html