On Thu, 2010-08-12 at 02:04 +0900, J. R. Okajima wrote: > Trond Myklebust: > > Yes. That looks correct. Can you resend with an appropriate signed-off > > line, etc.? > > Sure. Thank you! Applied... Trond > ---------------------------------------------------------------------- > commit e56f956a08a6227004cd9b7747df6a089dbb3594 > Author: J. R. Okajima <hooanon05@xxxxxxxxxxx> > Date: Thu Aug 12 02:00:02 2010 +0900 > > NFS: fix the return value of nfs_file_fsync() > > By the commit > af7fa16 2010-08-03 NFS: Fix up the fsync code > close(2) became returning the non-zero value even if it went well. > nfs_file_fsync() should return 0 when "status" is positive. > > Signed-off-by: J. R. Okajima <hooanon05@xxxxxxxxxxx> > > diff --git a/fs/nfs/file.c b/fs/nfs/file.c > index 2d141a7..eb51bd6 100644 > --- a/fs/nfs/file.c > +++ b/fs/nfs/file.c > @@ -323,7 +323,7 @@ nfs_file_fsync(struct file *file, int datasync) > have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags); > if (have_error) > ret = xchg(&ctx->error, 0); > - if (!ret) > + if (!ret && status < 0) > ret = status; > return ret; > } -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
