By the commit af7fa16 "NFS: Fix up the fsync code", close(2) seems to return the non-zero value even if it goes well, eg. the number of page via nfs_file_flush() vfs_fsync() nfs_file_fsync() nfs_commit_inode() nfs_scan_commit() nfs_scan_list() Should nfs_file_fsync() return 0 when "status" is positive? { status = nfs_commit_inode(inode, FLUSH_SYNC); ;;; - if (!ret) + if (!ret && status < 0) ret = status; } J. R. Okajima -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html