On Wed, Jun 09, 2010 at 07:38:04PM +1000, Nick Piggin wrote: > On Wed, Jun 09, 2010 at 05:29:37PM +0800, Tao Ma wrote: > > We have a inode_newsize_ok check at the top of ocfs2_setattr when we > > do the real work of truncate(it is far above, so the patch can't > > have it. ;) ). So we don't need to worry about that actually. > > OK, can you comment that or just open-code the truncate part of > simple_setsize? It should be helpful for example with Christoph's > truncate cleanup work. Just open-code it. The void calls are much nicer than useless return code boilerplate. Joel -- One look at the From: understanding has blossomed .procmailrc grows - Alexander Viro Joel Becker Principal Software Developer Oracle E-mail: joel.becker@xxxxxxxxxx Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html