On Wed, Jun 09, 2010 at 03:12:07AM -0700, Joel Becker wrote: > On Wed, Jun 09, 2010 at 07:38:04PM +1000, Nick Piggin wrote: > > On Wed, Jun 09, 2010 at 05:29:37PM +0800, Tao Ma wrote: > > > We have a inode_newsize_ok check at the top of ocfs2_setattr when we > > > do the real work of truncate(it is far above, so the patch can't > > > have it. ;) ). So we don't need to worry about that actually. > > > > OK, can you comment that or just open-code the truncate part of > > simple_setsize? It should be helpful for example with Christoph's > > truncate cleanup work. > > Just open-code it. The void calls are much nicer than useless > return code boilerplate. Note that if you rebase against vfs.git #for_next simple_setsize is replaced with a truncate_setsize that does all the work but the inode_newsize_ok check. As I mentioned before please do the work ontop of that branch, it does make the ->setattr ATTR_SIZE implementation much nicer for the filesystems. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
