On Wednesday 09 June 2010 15:30:16 Christoph Hellwig wrote:
> On Wed, Jun 09, 2010 at 03:29:14PM +0530, Nikanth Karthikesan wrote:
> > - truncate: Deprecated. This will not be called if ->setsize is defined.
> > - Called by the VFS to change the size of a file. The
> > + truncate: Deprecated. Called by the VFS to change the size of a file.
> > The i_size field of the inode is set to the desired size by the
>
> I'd just remove the whole description - the deprecated should be enough.
>
There is a note below the description, which should prevent new users.
Note: ->truncate and vmtruncate are deprecated. Do not add new
instances/calls of these. Filesystems should be converted to do their
truncate sequence via ->setattr().
But leaving it as it is would help, people understand how the deprecated
callback works. IMHO it could be left till all the users are converted.
Thanks
Nikanth
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
