On Mon, Oct 7, 2024 at 4:12 PM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > On Mon, Oct 07, 2024 at 01:01:56PM GMT, Amir Goldstein wrote: > > On Mon, Oct 7, 2024 at 12:38 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > > > On Mon, 7 Oct 2024 at 12:22, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > > > Maybe it is more straightforward, I can go with that, but it > > > > feels like a waste not to use the space in backing_file, > > > > so let me first try to convince you otherwise. > > > > > > Is it not a much bigger waste to allocate backing_file with kmalloc() > > > instead of kmem_cache_alloc()? > > > > Yes, much bigger... > > > > Christian is still moving things around wrt lifetime of file and > > backing_file, so I do not want to intervene in the file_table.c space. > > My plan was to just snatch your series on top of things once it's ready. > Sorry, I didn't get around to take a look. It seems even just closing > your eyes for a weekend to a computer screen is like opening flood > gates... Well I just posted v3 and it leaves backing_file alone which I also now agree with Miklos is looking much nicer. So whatever changes in lifetime of backing_file that you wanted to make feel free to make them. Thanks, Amir.
