On Sun, 6 Oct 2024 at 10:24, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > Hi all, > > This is v2 of the code to avoid temporary backing file opens in > overlayfs, taking into account Al's comments on v1 [1]. > > Miklos, > > The implementation of ovl_real_file_path() helper is roughly based on > ovl_real_dir_file(). > > do you see any problems with this approach or any races not handled? > Note that I did have a logical bug in v1 (always choosing the stashed > upperfile if it exists), so there may be more. Stashing the upper file pointer in the lower file's backing struct feels like a layering violation. Wouldn't it be cleaner to just do what directory files do and link both upper and lower backing files from the ovl file? Thanks, Miklos
